Fix call stack exceeded bug #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, will fix |
jstarry
force-pushed
the
fix-call-stack
branch
from
c126de8
to
3ca5c71
Compare
jstarry
added a commit
that referenced
this pull request
Oct 18, 2020
* Fix call stack exceeded bug * Fix borrow error * Update scope node_ref copy when component updates
siku2
pushed a commit
to siku2/yew
that referenced
this pull request
Oct 20, 2020
* Fix call stack exceeded bug * Fix borrow error * Update scope node_ref copy when component updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever a component re-renders, the new component links to the old component's node ref and if this repeats long enough, the call stack will be exceeded.
Rather than link, the new component should reuse the existing node ref
Fixes #1449
Checklist
cargo make pr-flow